[Bug 775070] asfdemux: ASF object size checks

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Nov 25 10:52:12 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=775070

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340735|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340735:
 --> (https://bugzilla.gnome.org/review?bug=775070&attachment=340735)

Looks good

::: gst/asfdemux/gstasfdemux.c
@@ +1119,3 @@
     bufdata = (guint8 *) map.data;
+    obj_size = obj.size;
+    ret = gst_asf_demux_process_object (demux, &bufdata, &obj_size);

Why don't you continue passing obj.size (and change all the things to
guint32*)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list