[Bug 775071] memory leak in usage of gst_pad_get_current_caps() API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775071

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340738|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340738:
 --> (https://bugzilla.gnome.org/review?bug=775071&attachment=340738)

Please provide patches in "git format-patch" format with a meaningful commit
message, thanks! :)

::: gst-plugins-good-1.10.1/gst/rtp/gstrtph264depay.c
@@ +441,2 @@
   gst_caps_unref (srccaps);
+  gst_caps_unref (old_caps);

old_caps might be NULL here. Unref them in the if above

::: gst-plugins-good-1.10.1/gst/rtp/gstrtpsbcdepay.c
@@ +183,2 @@
   gst_caps_unref (outcaps);
+  gst_caps_unref (oldcaps);

Same

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.