[Bug 775072] memory leak in usage of gst_pad_get_current_caps() API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775072

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340741|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340741:
 --> (https://bugzilla.gnome.org/review?bug=775072&attachment=340741)

Please provide patches in "git format-patch" format with a meaningful commit
message, thanks!

::: gst-plugins-bad-1.10.1/gst/mpegpsmux/mpegpsmux.c
@@ +231,3 @@
   s = gst_caps_get_structure (caps, 0);
+
+  gst_caps_unref (caps);  

This will invalidate "s", which is still used afterwards. You can only unref
after "s" is not used anymore

::: gst-plugins-bad-1.10.1/tests/examples/directfb/gstdfb.c
@@ +89,3 @@
   s = gst_caps_get_structure (caps, 0);
+ 
+  gst_caps_unref (caps);  

same

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.