[Bug 768794] ion: DMA Buf allocator based on ion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768794

--- Comment #36 from Benjamin Gaignard <benjamin.gaignard at gmail.com> ---
Review of attachment 340730:
 --> (https://bugzilla.gnome.org/review?bug=768794&attachment=340730)

::: gst-libs/gst/allocators/gstionmemory.c
@@ +126,3 @@
+
+  fd_data.handle = ion_handle;
+  ret = gst_ion_ioctl (self->fd, ION_IOC_MAP, &fd_data);

maybe you can use ION_IOC_SHARE instead of ION_IOC_MAP, it does the same but
the name is less confusing

@@ +188,3 @@
+  /* ION_IOC_IMPORT will add one ref for ion handle. */
+  gst_ion_ioctl (self->fd, ION_IOC_FREE, &handle_data);
+  gst_ion_ioctl (self->fd, ION_IOC_FREE, &handle_data);

Why are you doing ION_IOC_IMPORT and 2 ION_IOC_FREE ?
I believe that just close the fd is enough

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.