[Bug 775130] New: h264 parser: invalid input causes assert

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775130

            Bug ID: 775130
           Summary: h264 parser: invalid input causes assert
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: hanno at hboeck.de
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 340789
  --> https://bugzilla.gnome.org/attachment.cgi?id=340789&action=edit
poc file

The attached file will cause a call to an assert.

This happens in the file gst/videoparsers/gsth264parse.c (line 1134 in current
git). After a call to gst_h264_parser_identify_nalu_unchecked() a switch/case
statement checks for return values GST_H264_PARSER_OK and
GST_H264_PARSER_NO_NAL and for all other values calls g_assert_not_reached.

However the function (file gst-libs/gst/codecparsers/gsth264parser.c) can also
return GST_H264_PARSER_ERROR. Therefore this should be added to the switch/case
statement and returned with a graceful error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.