[Bug 774983] avdec_h264 is not copying metadata to the outputbuffer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774983

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
I'm not convinced of the resolution is ideal. It's not fully the fact that the
memory are mapped read-write, but the fact that the GstBuffer has a refcount of
two. It's somehow a side effect, but in your case, calling
gst_buffer_make_writable() is free, it will only create a new GstBuffer and ref
the memory.

Of course you'll be doing more allocation, but it will work without serious
performance (this is low rate, since it's video). To me, the bug is that your
new code is not calling make_writable(), the result is not optimal, the
remaining would require finding a workaround to the way libav works.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.