[Bug 774657] add proxy control binding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774657

--- Comment #8 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
(In reply to Matthew Waters (ystreet00) from comment #7)
> (In reply to Stefan Sauer (gstreamer, gtkdoc dev) from comment #5)
> > I saw this a bit late, but please improve the doc blob. It should tell what
> > is this good for.
> > 
> > "
> > A #GstControlBinding that forwards requests to another #GstControlBinding.
> > "
> > 
> > is not giving people enough to understand in what situations this is useful.
> 
> For exactly ^.
> 
> You have two objects.  You need to forward the control binding from one
> property on one object to another property on another object.
> 
> > TBH, I also don't understand the commit message
> > 
> > "
> > E.g. in a parent-child relationship, one may need to
> > gst_object_sync_values() on the child and have a binding (set elsewhere)
> > on the parent update the value.
> > "
> > 
> > Do you have a concrete example?
> 
> glvideomixer/glsinkbin.  sync_values() on the child pad/element will call
> sync_values on the exposed bin pad/element.
>
So far I did this in the parent (calling gst_element_sync_values on the
children). But in your case it seems to be that child and parent also expose
the same property, right?

> 
> (In reply to Stefan Sauer (gstreamer, gtkdoc dev) from comment #6)
> > Oh and thanks for adding a test, but please break this down into multiple
> > tests. If the tests fails, one just know that *something* called
> > controller_proxy is broken. Having several tests allows you to tell what you
> > test in the test name.
> 
> How would I break this down?
> 
> All the implementation does is forward to the necessary control binding. 
> There isn't really a logical split of functionality to test.

I disagree, I'll post review comment now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.