[Bug 775072] memory leak in usage of gst_pad_get_current_caps() API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775072

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340874|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340874:
 --> (https://bugzilla.gnome.org/review?bug=775072&attachment=340874)

Please put the URL to the bug report as last line in the commit message. And
the patch still has the same problems as before:

::: gst/mpegpsmux/mpegpsmux.c
@@ +231,2 @@
   s = gst_caps_get_structure (caps, 0);
+  gst_caps_unref (caps);

"s" becomes invalid by unreffing the caps that own it. Only unref the caps
after all usage of the GstStructure is done.

::: tests/examples/directfb/gstdfb.c
@@ +89,2 @@
   s = gst_caps_get_structure (caps, 0);
+  gst_caps_unref (caps);

Same

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.