[Bug 773546] vaapiencoders: race condition when multiple encoders

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Nov 28 16:09:25 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=773546

--- Comment #28 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #27)
> (In reply to Víctor Manuel Jáquez Leal from comment #26)
> > Perhaps we should call ensure_profiles() as soon as possible, rather of a
> > lazy evaluation, thus we could avoid the mutexes in that function.
> 
> What do you think about calling ensure_profiles/image_formats during
> creation of vaapi display?

Noup. My idea is to keep that in the encoders, which are the ones that show
that behavior.

But if that is not possible, and we ought keep this mutex-based solution, I
would change the patch renaming the function ensure_profile() to
ensure_profile_unlock() and create a new function named ensure_profile() with a
single all to the unlock version inside a LOCK/UNLOCK pair.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list