[Bug 775288] opencv: base opencv video filter class does not fully implement the video filter contract

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775288

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Created attachment 340958
  --> https://bugzilla.gnome.org/attachment.cgi?id=340958&action=edit
Ok, I've actually looked at the code and you are right. There is one important

issue that I notice is that the frame stride is completly ignored. This is 
bad because the base class advertise GstVideoMeta support. Might have felt
guilty, but I completed the port to GstVideoFilter. Note, I omitted the
set_info() part, where we could add an optimized helper to prevent parsing
the caps into GstVideoInfo a second time. That didn't feel urgent enough for
tonight.

If anyone wonder why I'm not just merging this, well, it'S late, I'd like to
test a bit more then just running faceoverlay for 5s. The patch message:

opencvfilter: Properly port to GstVideoFilter

This is a subblass of VideoFilter but yet does not use any of it's
features. This also fixes issue in case the incoming images have custom
strides as the VideoMeta is no longer ignored.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.