[Bug 775288] opencv: base opencv video filter class does not fully implement the video filter contract

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775288

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Philippe Renon from comment #7)
> Minor nitpicks:
> 
> +  vfilter_class->transform_frame = gst_opencv_video_filter_transform_frame;
> +  vfilter_class->transform_frame_ip =
> gst_opencv_video_filter_transform_frame_ip;
> +  vfilter_class->set_info = gst_opencv_video_filter_set_info;
> ^ set_info should come first ? (same applies where the protorypes are
> declared and other places...).

Ok.

> 
> 
> +  transform->out_cvImage->imageData = (char *) outframe->data[0];
> +  transform->out_cvImage->imageSize = outframe->info.size;
> +  transform->out_cvImage->widthStep = outframe->info.stride[0];
> ^ there are macros to extract those items from a GstVideoFrames.

I know, it's been many many years, and I still don't see the point of using
them ;-P

> 
> +  ret = fclass->cv_trans_ip_func (transform, frame->buffer,
> transform->cvImage);
> ^ my patch will take care of renaming the vfuncs to proper names (i.e.
> cv_transform_frame_ip) and passing GstVideoFrame in place of GstBuffer,
> which will impact all elements deriving from gstopencvvideofilter.

This is quite intrusive. What do we gain from that ? I guess I need to go over
the elements to see. I would be tempted to just remove the GstBuffer if
possible, and only have IplImage in there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.