[Bug 775288] opencv: base opencv video filter class does not fully implement the video filter contract

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775288

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Element that uses the GstBuffer:

cvlaplace/cvsobel/edgedetect/
- it already have the mapped buffer in outimage
- ignores GstVideoMeta
- ignored buffer_map return value.

facedetect/motioncells:
- The VideoFilter ensure the buffer is writable
+ Fair use of the timestamps to post message

tmplatematch:
- The usage of buf make no sense at all

So the only use I found is for timestamps, we could just pass that. Random
calls to make-writable are really odd (looks like porting errors, from 0.10 to
1.0). Conclusion there is a lot more cleanup to do. I'll do the small changes
you proposed.  If you feel like attaching patches to create an interesting
cleanup collection, that would be nice. Please, create small patch. One big
intrusive patch is really annoying to review.

In general, I believe if we provide less, it will avoid wrong usage. Clearly
someone didn't know what he was doing. Now, this is arguably a baseclass in a
library, so flexibility is also important. But let's cleanup up all the usage
to the buffer to be limited to timestamp as it's supposed. This will also
remove couple of useless copies. Then we can probably think about what should
the library interface be. I don't think we'll be moving those to -good in this
cycle.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.