[Bug 775351] New: multihandlesink: buffers-queued is off by one

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775351

            Bug ID: 775351
           Summary: multihandlesink: buffers-queued is off by one
    Classification: Platform
           Product: GStreamer
           Version: 1.10.1
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: jan.steffens at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 340988
  --> https://bugzilla.gnome.org/attachment.cgi?id=340988&action=edit
[PATCH] multihandlesink: Fix buffers-queued being off by one

Diving into multifdsink/multihandlesink's code convinced me that the
buffers-queued property is off by one, since max_buffer_usage is actually the
index of the oldest buffer, not the number of buffers queued.

find_limits returns the index of the oldest buffer that satisfies the limits in
its min_idx parameter, not the number of buffers needed. Fix this use too in
order to keep passing the tests that read buffers-queued.

Leave the starting value of max_buffer_usage alone, as find_limits will raise
it to 0 anyway, ensuring at least one buffer in the queue. I don't know whether
always keeping one buffer is desirable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.