[Bug 775288] opencv: base opencv video filter class does not fully implement the video filter contract

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775288

--- Comment #12 from Philippe Renon <philippe_renon at yahoo.fr> ---
About naming:

1/ Some elements are prefixed by cv (cvlaplace, cvsobel) while others are not
(edgedetect, facedetect). What would be the preferred convention ? Don't worry,
if I rename them it will be one of the last patch...

2/ When passing a GstOpencvVideoFilter element as an argument, the argument
name should not be trans or what not. I suggest to use cvfilter (same as
vfilter for a GstVideoFilter).

3/ Most concrete elements, do something like this:
    GstCvSobel *filter = GST_CV_SOBEL (base);
According to 2/ it should be:
    GstCvSobel *filter = GST_CV_SOBEL (cvfilter);
And better (?) :
    GstCvSobel *cvsobel = GST_CV_SOBEL (base);
I am not sure what the current/recommended convention is.
Variable names can get quite long for some elements (GstTemplateMatch, ...)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.