[Bug 775292] dtls: Set openssl's threadid the 1.0.x way

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775292

Scott D Phillips <scott.d.phillips at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340952|needs-work                  |none
             status|                            |
 Attachment #340952|0                           |1
        is obsolete|                            |

--- Comment #4 from Scott D Phillips <scott.d.phillips at intel.com> ---
Created attachment 340990
  --> https://bugzilla.gnome.org/attachment.cgi?id=340990&action=edit
[PATCH gst-plugins-bad v2] dtls: Set openssl's threadid the 1.0.x way

(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 340952 [details] [review]:
> 
> ::: ext/dtls/gstdtlsagent.c
> @@ +150,3 @@
>        CRYPTO_set_id_callback (ssl_thread_id_function);
> +#else /* OPENSSL_VERSION_NUMBER >= 0x10000000L */
> +      CRYPTO_THREADID_set_callback (ssl_thread_id_function);
> 
> In 1.1, the first function is hard-deprecated (#if OPENSSL_API_COMPAT <
> 0x10000000L) and the second is #defined to a no-op. Let's add another #ifdef
> to just not call any of these for 1.1?

The logic to ifdef out all of this in 1.1 and later was already there but was
getting a bit messy with my previous change. Looking at it again I realized
that dtls already requires 1.0.1 or later, so a cleaner change is to just dump
the 0.9.x way altogether.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.