[Bug 775288] opencv: base opencv video filter class does not fully implement the video filter contract

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 29 20:06:54 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=775288

--- Comment #16 from Philippe Renon <philippe_renon at yahoo.fr> ---
(In reply to Nicolas Dufresne (stormer) from comment #15)
> Ok, I have an argument against, we usally want to use generic name for the
> local object. I prefer using "self", but other can use generic names like
> filter. The point is that it helps reusing the code elsewhere, in cases you
> need similar but different code.

Ok. Point taken. I agree on the generic name approach.
- Makes it easier to scan code and move it around.
- Does not ask you to be creative where it brings little value.
- Generic names are usually shorter...

I felt quite uneasy with the result of the non generic approach.

I'll try self or leave filter.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list