[Bug 775071] memory leak in usage of gst_pad_get_current_caps() API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775071

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341020|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341020:
 --> (https://bugzilla.gnome.org/review?bug=775071&attachment=341020)

::: gst/rtp/gstrtpsbcdepay.c
@@ +179,3 @@
     /* Caps have changed, flush old data */
     gst_adapter_clear (depay->adapter);
+    gst_caps_unref (oldcaps);

You leak oldcaps if they are not NULL but can intersect with caps. Just put a
"if (oldcaps) gst_caps_unref (oldcaps)" after the whole if

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.