[Bug 775369] Audio distortion since commit 010b954 (regression)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775369

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This probably fixes it:

commit 1e648002782755d6ff3de7b948d89e6195924c44
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed Nov 30 10:48:40 2016 +0200

    audioconvert: Don't map the input buffer in in-place mode

    Input and output buffer are the same, let's not do unnecessary work.

    https://bugzilla.gnome.org/show_bug.cgi?id=775369

commit 71e819ae7dafb0077179ae7fa7a014c464811687
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed Nov 30 10:43:50 2016 +0200

    audio-converter: In passthrough, also don't copy if in and out block are
the same

    In and out array are usually different, they are stack allocated arrays.
    However the blocks inside them still can be the same.

    https://bugzilla.gnome.org/show_bug.cgi?id=775369

commit 1631a3864024a4a8b137b24906e2d76b94f2f47d
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed Nov 30 10:36:14 2016 +0200

    audioconvert: Don't call transform_ip() in passthrough mode

    https://bugzilla.gnome.org/show_bug.cgi?id=775369


But nonetheless there is a problem here. There should be no distortion, there
should be no effect at all on the audio even if we run it through the
transform. That it is distorted suggests that the converter_passthrough()
function is wrong, however here it is called with in==out and does absolutely
nothing then. It just calls a memcpy(), which suggests that something is wrong
with your libc or your hardware.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.