[Bug 772330] adaptivedemux: Improve bitrate estimation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772330

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #336753|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 336753:
 --> (https://bugzilla.gnome.org/review?bug=772330&attachment=336753)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +2375,3 @@
+        stream->last_latency =
+            gst_adaptive_demux_get_monotonic_time (stream->demux) -
+            (stream->download_start_time * GST_USECOND);

While it is currently true here that we only receive the SEGMENT event right
before the first buffer, this does not seem guaranteed. There's nothing that
forbids sending the SEGMENT event right away (or sending multiple ones).

It would probably be better to watch out for the actual first buffer

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.