[Bug 768763] vorbisenc, opusenc reconfiguration broken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768763

--- Comment #40 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Vincent Penquerc'h from comment #39)
> There's some automatic accounting for this (end of 1.3.2 in doc/index.html
> in libvorbis):
> 
> >    Data is not returned from the first frame; it must be used to ’prime’ the decode engine. The encoder
> >    accounts for this priming when calculating PCM offsets; after the first frame, the proper PCM output
> >    offset is ’0’ (as no data has been returned yet).
> 
> I don't think there's anything else to do about this.

So it seems, simpler than Opus then ;)

> As for my question about incoming buffers, it is: if I get a raw PCM buffer
> of 100 samples, and there is a clip meta on it with start=20 and end=20,
> those presumably need to be applied to the outgoing buffer as well, right
> (and, with this patch, the end needs to be set to max(20, X) if X is the
> result of the calculation in this patch) ?

clip meta is only really supposed to be on encoded data, and it is
applied/consumed after decoding. It makes no sense on raw PCM buffers, adding a
meta is more work than just creating a subbuffer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.