[Bug 772554] New: libs: minor correction for logical consistency

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Oct 7 09:59:34 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=772554

            Bug ID: 772554
           Summary: libs: minor correction for logical consistency
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: minor
          Priority: Normal
         Component: gstreamer-vaapi
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: zzoon at igalia.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: bsreerenj at gmail.com, vjaquez at igalia.com
     GNOME version: ---

There are some logically invalid ref/unref methods, which are being used.

1. GstVaapiDecoder is inherited from GstVaapiMiniObject.
But it call gst_vaapi_object_replace instead of gst_vaapi_mini_object_replace

2. GstVaapiPixmap,Window,Texture are inherited from GstVaapiObject.
But it call gst_vaapi_mini_object_ref/unref/replace directly.

These are not critical because gst_vaapi_object_ref/unref/replace calls
gst_vaapi_mini_object_ref/unref/replace directly.

But for consistency, we should change this, IMO.
Especially for 1, it should be changed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list