[Bug 772555] debug: Implement gst_debug_print_stack_trace with libunwind/backtrace when avalaible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772555

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337146|none                        |needs-work
             status|                            |

--- Comment #6 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 337146:
 --> (https://bugzilla.gnome.org/review?bug=772555&attachment=337146)

::: configure.ac
@@ -792,0 +792,8 @@
+if test "x$HAVE_UNWIND" = "xyes"; then
+  AC_DEFINE(HAVE_UNWIND, 1, [libunwind available])
+fi
... 5 more ...

Add it to the config summary displayed at the end of configure?

::: gst/gstinfo.c
@@ +2387,2 @@
  *
  * If GST_ENABLE_FUNC_INSTRUMENTATION is defined a stacktrace is available for

The doc is miss-leading as we have now an implementation working even if
GST_ENABLE_FUNC_INSTRUMENTATION isn't defined.

@@ +2431,3 @@
+#ifdef HAVE_DW
+#include <elfutils/libdwfl.h>
+#include <stdlib.h>

It's already included above.

@@ +2441,3 @@
+    .find_elf = dwfl_linux_proc_find_elf,
+    .find_debuginfo = dwfl_standard_find_debuginfo,
+#include <assert.h>

We're not responsible of freeing this? (just double checking).

@@ +2445,3 @@
+
+  Dwfl *dwfl = dwfl_begin (&callbacks);
+#ifdef HAVE_DW

any reason to not use g_assert()?
I guess you just copy/paste this magic rune but may be worth making it a bit
glib-ish.

@@ +2454,3 @@
+  Dwfl_Module *module = dwfl_addrmodule (dwfl, addr);
+
+{

Move var declarations at the start of the function?

@@ +2546,3 @@
+#endif /* HAVE_BACKTRACE */
+
+

Double \n

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.