[Bug 772608] rpi/dispmanx: Implement gst_video_overlay_set_window_handle() for dispmanx window

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772608

--- Comment #22 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to Munez from comment #21)
> > > b] When you say copy foreign handle did you mean copying only dispmanx
> > > element ? i.e  window_egl->native.element = window_egl->foreign.element.
> > 
> > We copy all of it, the element, width and height.
> When we copy window_egl->native.element = window_egl->foreign.element we
> loose the reference of native_window element which was created (16x16)
> before foreign window set so we need it remove it before assigning foreign
> element

ACK.

> Like explained above, a native window element is always created before
> foreign window element is set.
> 
> I think this is what we should do.. we need to modify only 2 functions
> 
> 1] Modify gst_gl_window_dispmanx_egl_set_window_handle()
>   a] Store user window in a new member : "foreign"
>   b] If "native" element is already set, then remove it from layer
>   c] Copy "foreign" into "native" completely
> 
> 2] Modify gst_gl_window_dispmanx_egl_close()
>    a] If "native" element is set and it is same as "foreign" element then
> don't remove it from layer.
> 
> Kindly let me know if this is ok. I will update the patch.

Looks good to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.