[Bug 772742] mpegtsdemux: Implement efficient program updates

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Oct 12 13:42:39 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=772742

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337397|committed                   |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 337397:
 --> (https://bugzilla.gnome.org/review?bug=772742&attachment=337397)

more review later

::: gst/mpegtsdemux/mpegtsbase.c
@@ +213,3 @@
+  base->streams_aware = GST_OBJECT_PARENT (base)
+      && GST_OBJECT_FLAG_IS_SET (GST_OBJECT_PARENT (base),
+      GST_BIN_FLAG_STREAMS_AWARE);

This is not threadsafe and will also be wrong if the element is added to the
bin after this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list