[Bug 772451] Broken clock_gettime and mkostemp detection with XCode 8

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772451

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Both patches pushed.

gstreamer:

commit 6c1bc80d2791af9a5b07d59ce8e6f7039577eece
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Mon Oct 3 20:22:53 2016 +0530

    build: Fix clock_gettime check with XCode 8

    With XCode 8, clock_gettime will be incorrectly detected as being
    available regardless of what OS X version we're targetting because the
    symbol is available in the .tbd library as a weak symbol.
    See: https://github.com/Homebrew/homebrew-core/issues/3727#issue-170086273

    It's only starting from macOS 10.12 that clock_gettime is actually
    available, so we can unconditionally disable it when targetting older
    versions. We cannot simply do AC_CHECK_FUNCS with -Wl,-no_weak_imports
    because the autoconf check does its own prototype declaration that
    doesn't trigger that compiler flag.

    https://bugzilla.gnome.org/show_bug.cgi?id=772451


Cerbero:

commit 45da4d69c1ce52d7e8c8e77477ac327bdc99ca7f
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Fri Oct 7 23:03:19 2016 +0530

    Workaround broken XCode 8 SDK weak symbol detection

    macOS 10.12 added a bunch of new symbols: clock_gettime, getentropy,
    mkostemp, etc. These are available in the macOS 10.12 SDK. However,
    XCode 8 now only ships that version of the SDK, and because of the way
    the symbols are defined, they are always detected as being available
    regardless of what OS X version you are actually targetting.

    Long story short, the only way around this is to workaround it by
    forcibly disabling detection of these symbols when we're targetting OS
    X versions older than 10.12. For more details, see:
    https://bugzilla.gnome.org/show_bug.cgi?id=772451

commit 94182f84b5ad6c715a70bb90fa6e4b4d488aa3dc
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Fri Oct 7 23:12:59 2016 +0530

    osx: Don't build GNU tar in build-tools

    We don't even use tar for unpacking, and it seems BSD tar is enough for
    everything else.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.