[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768266

--- Comment #33 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Hyunjun Ko from comment #32)
> Created attachment 337551 [details] [review]
> vaapiobject: change vaapiobject to be inherited from GstMiniObject
> 
> For performance, use GstMiniObject not GstObject.
> 
> To use GstMiniObject for GstVaapiObject,
> 1. Cut the relation with GstVaapiMiniObject and inherit from GstMiniObject
> 2. Keep it up using object_class to support for subclassing
> 3. Make children of GstVaapiObject to be GBoxed type to give type name to
> each object.

Note that the patch on #772554 should be merged, otherwise crash happens.

I was trying to work on VaapiSurface first, but realized it's much more
difficult. It's because vaapivideopool handles every type of vaapi object
without type checking.

Now I'm testing with this patch, I didn't see any problem yet. But we should
keep verifying as much as we can.

By the way, I found a leak in case of using wayland backend thanks to this
patch :) I'm going to file this issue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.