[Bug 758717] bayer: pixel aspect ratio not forwarded when transforming caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758717

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337609|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 337609:
 --> (https://bugzilla.gnome.org/review?bug=758717&attachment=337609)

Except for the set_name() part, it looks correct to me.

::: gst/bayer/gstbayer2rgb.c
@@ +299,3 @@
+    structure = gst_caps_get_structure (res_caps, i);
+    if (direction == GST_PAD_SINK) {
+      gst_structure_set_name (structure, "video/x-raw");

That one is not needed, since your caps template will ensure that already.

@@ +302,3 @@
+      gst_structure_remove_field (structure, "format");
+    } else {
+      gst_structure_set_name (structure, "video/x-bayer");

And same.

@@ +304,3 @@
+      gst_structure_set_name (structure, "video/x-bayer");
+      gst_structure_remove_fields (structure, "format", "colorimetry",
+          "chroma-site", NULL);

Curiosity (not a review comment), do we just ignore these and do we actually
handle it in the conversion already ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.