[Bug 772835] videooverlaycomposition: Need unref composition when remove video overlay composition meta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772835

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Tim-Philipp Müller from comment #4)
> > Interesting, that means when we add a video meta, unless we
> > cache the composition, we need to drop the extra ref.
> 
> In the usual case you attach the same composition to many video buffers, so
> that seems to make sense, no?

I don't remember exactly, I thought we could re-use the GstMeta, which makes
caching of the composition less useful. I need to re-read some code, I didn't
notice, and may have introduced leaks all over there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.