[Bug 773002] netsim: more features and love
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Oct 18 17:32:01 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=773002
Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #337768|none |reviewed
status| |
--- Comment #5 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 337768:
--> (https://bugzilla.gnome.org/review?bug=773002&attachment=337768)
Did you think of adding a "simulated" IP/UDP header to each packet. I guess for
video it won't matter much, but for audio it probably would.
::: gst/netsim/gstnetsim.c
@@ -74,3 +82,2 @@
#define GST_NET_SIM_GET_PRIVATE(o) \
- (G_TYPE_INSTANCE_GET_PRIVATE ((o), GST_TYPE_NET_SIM, \
- GstNetSimPrivate))
+ (G_TYPE_INSTANCE_GET_PRIVATE ((o), GST_TYPE_NET_SIM, GstNetSimPrivate))
Did you run it through the gst-indent script?
@@ +100,3 @@
gst_net_sim_loop (GstNetSim * netsim)
{
+ GstNetSimPrivate *priv = netsim->priv;
Any chance you can separate the stylistic changes?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list