[Bug 771830] There is no time out in idle connection RTSP server
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Oct 19 09:46:13 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=771830
Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #336087|none |reviewed
status| |
--- Comment #6 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 336087:
--> (https://bugzilla.gnome.org/review?bug=771830&attachment=336087)
This seems ok.
::: gst/rtsp-server/rtsp-client.c
@@ +1835,3 @@
+ priv->rtsp_ctrl_timeout_cnt += RTSP_CTRL_CB_INTERVAL;
+
+ if (priv->rtsp_ctrl_timeout_cnt > RTSP_CTRL_TIMEOUT_VALUE)
Not entirely sure if this matters but the GSource will most likely not fire
exactly every second due to system performance/rounding/etc. If you want to
accurately track time periods over a larger period of time, storing the current
timestamp and comparing the current against the saved is a much better approach
(IIRC, GSource has something to get the current wakeup time so that every
GSource doesn't spam g_get_monotonic_time()).
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list