[Bug 772527] [Patch] Parse SDT, TDT and TOT messages in DVB stream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772527

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337102|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 337102:
 --> (https://bugzilla.gnome.org/review?bug=772527&attachment=337102)

Maybe these should be moved into libgsttag into a separate namespace for dublin
core? But generally seems fine to have them in core I guess, except for:

::: gst/gsttaglist.h
@@ +485,3 @@
+#define GST_TAG_COVERAGE               "coverage"
+/**
+ * GST_TAG_IDENTIFIER:

This seems a bit generic. DUBLIN_CORE_IDENTIFIER maybe?

@@ +505,3 @@
+ * Since: 1.9
+ */
+#define GST_TAG_LANGUAGE               "language"

There's also LANGUAGE_NAME and LANGUAGE_CODE. How is this one different?

@@ +507,3 @@
+#define GST_TAG_LANGUAGE               "language"
+/**
+ * GST_TAG_PUBLISHER:

There already is GST_TAG_PUBLISHER since 1.2

@@ +540,3 @@
+#define GST_TAG_SOURCE                 "source"
+/**
+ * GST_TAG_GENRE:

GST_TAG_GENRE exists since forever already

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.