[Bug 772555] debug: Implement gst_debug_print_stack_trace with libunwind/backtrace when avalaible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772555

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337334|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 337334:
 --> (https://bugzilla.gnome.org/review?bug=772555&attachment=337334)

::: gst/gstinfo.c
@@ +2423,3 @@
+#include <stdarg.h>
+#include <unistd.h>
+#include <errno.h>

Including things in the middle of the file between other functions often causes
problems. Better put this at the top in a separate #ifdef

@@ +2439,3 @@
+    .find_elf = dwfl_linux_proc_find_elf,
+    .find_debuginfo = dwfl_standard_find_debuginfo,
+    .debuginfo_path = &debuginfo_path,

Isn't this C99?

@@ +2465,3 @@
+        &nline, NULL, NULL, NULL);
+
+    g_string_append_printf (trace, "%s:%d", strrchr (filename, '/') + 1,
nline);

Instead of '/', use the path separator #define from GLib

::: meson.build
@@ +243,3 @@
+else
+  if cc.has_function('backtrace')
+    cdata.set('HAVE_BACKTRACE', 1)

In meson you have either BACKTRACE or UNWIND, in autotools you can have both at
once

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.