[Bug 773093] basetransform: Fix race when toggling passthrough

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773093

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337841|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 337841:
 --> (https://bugzilla.gnome.org/review?bug=773093&attachment=337841)

I'm worried of the performance impact of this here. Wouldn't it be better to
remember passthrough throughout the processing of a single buffer at the very
beginning, and not allow changing it on the way? This doesn't seem like
something meaningful to do anyway. Or I'm misunderstanding the problem here :)

::: libs/gst/base/gstbasetransform.c
@@ +2053,3 @@
    */
+  if (!priv->negotiated && !priv->passthrough &&
+      (bclass->set_caps != NULL))

Shouldn't this here also take the lock?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.