[Bug 773092] gstinfo: Replace %p and %r in GST_DEBUG_FILE

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773092

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337840|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 337840:
 --> (https://bugzilla.gnome.org/review?bug=773092&attachment=337840)

::: gst/gstinfo.c
@@ +314,3 @@
+
+  name = g_strdup (env);
+  name = _replace_pattern_in_gst_debug_file_name (name, "%p", getpid ());

Is getpid() portable? Do we need different includes, configure checks, etc for
this?

@@ +315,3 @@
+  name = g_strdup (env);
+  name = _replace_pattern_in_gst_debug_file_name (name, "%p", getpid ());
+  name = _replace_pattern_in_gst_debug_file_name (name, "%r", g_random_int
());

You probably want to replace this with a fixed number of digits, e.g. %08x

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.