[Bug 773090] paramspecs: Add int range

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773090

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337838|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 337838:
 --> (https://bugzilla.gnome.org/review?bug=773090&attachment=337838)

Generally makes sense (maybe do the same for the other ranges and use a macro
to generate code?) but:

::: gst/gstparamspecs.c
@@ +240,3 @@
+  g_return_val_if_fail (gst_value_get_int_range_step (value) > 0, TRUE);
+
+  if (gst_value_get_int_range_max (value) < gst_value_get_int_range_min
(value)) {

If max < min, all is ok? Shouldn't it be the other way around... and don't you
want to check here if min <= value <= max here anyway?

@@ +242,3 @@
+  if (gst_value_get_int_range_max (value) < gst_value_get_int_range_min
(value)) {
+    gst_value_set_int_range (value, gst_value_get_int_range_min (value),
+        gst_value_get_int_range_min (value));

And what's the point of this? :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.