[Bug 773207] audio-converter: incorrect use of memcpy for in-place conversion in do_unpack()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773207

--- Comment #7 from Petr Kulhavy <brain at jikos.cz> ---
(In reply to Sebastian Dröge (slomo) from comment #6)

> Adding an assertion for the memcpy() would still seem useful here, or don't
> you think?

It is actually not needed. The long if:

if (!chain->allow_ip || !in_writable || !convert->in_default)

takes care of that. The condition is equal to !(chain->allow_ip && in_writable
&& convert->in_default) which is exactly the only case when the memcpy() is
called with dst==src.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.