[Bug 773217] qtmux: Allow configuring the maximum interleave size in bytes/time

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773217

--- Comment #5 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 338008:
 --> (https://bugzilla.gnome.org/review?bug=773217&attachment=338008)

Looks good, but perhaps just naming the property interleave-time and
interleave-bytes without the 'max' makes it clearer?

I feel that the max passes the impression that it will interleave as usual by
time but will start a new chunk once the threshold is reached while this
property is actually a fixed interleaving interval. It will consume from pads
until it is reached. In short, 'max' passes the impression of threshold but
anything below it is fine while without the 'max' gives me a 'target'
impression.

::: gst/isomp4/gstqtmux.c
@@ +3569,3 @@
+      if (tmp_buf)
+        gst_buffer_unref (tmp_buf);
+    }

I'd move this early pad selection to a separate function, but this can be done
as a separate commit just to make things more modular.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.