[Bug 773073] audioconvert: endian conversion optimization

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Oct 20 13:43:46 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=773073

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338099|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338099:
 --> (https://bugzilla.gnome.org/review?bug=773073&attachment=338099)

::: gst-libs/gst/audio/audio-converter.c
@@ +879,3 @@
+        :"r" (in)
+        :"memory", "d0", "d1");
+  }

Don't add assembly code here, but use orc instead. See the existing orc code
for the conversion. The swap* opcodes are what you want here

@@ +1117,3 @@
+        convert->convert = converter_endian;
+
+        switch (in_info->bpf / in_info->channels) {

in_info->bps :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list