[Bug 773269] rtpbin: avoid generating rtcp messages in early timeouts for sources not requesting it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773269

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
No, the patch prevents applications from appending more RTCP packets for a
source (that has nothing else pending) via the on-sending-rtcp signal. The
application would have to wait for the next regular schedule again (or an early
schedule with actual packets for this specific source).


But I see what the problem is now. RTCP is scheduled per session, not per
source. And some sources in the session might not have anything to report and
thus an empty packet.

An alternative patch would make sense then, that moves the warning out of the
loop. And only warns if *none* of the sources had a non-empty packet (i.e. if
the whole session was scheduled without need). Does that make sense to you?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.