[Bug 773218] rtpbin: pipeline gets an EOS when any rtpsources byes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773218

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338180|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338180:
 --> (https://bugzilla.gnome.org/review?bug=773218&attachment=338180)

Not sure I understand. What should happen here AFAIU is that the whole session
goes EOS if all sources are BYE. How is your patch doing that?

::: gst/rtpmanager/gstrtpsession.c
@@ +1158,3 @@
     GST_RTP_SESSION_LOCK (rtpsession);
+
+    if (!rtp_session_get_num_sources (session)) {

Is the source removed from the session whenever it goes BYE? And that here then
makes sure to EOS if no sources are left? Not sure if we should distinguish
between internal sources or not (i.e. should we care that a remote source did
not BYE yet?), and if this session is sending or only receiving.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.