[Bug 772646] rtpjitterbuffer: fix lost-event using dts instead of pts

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772646

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Håvard Graff (hgr) from comment #3)

> > @@ +2832,3 @@
> >  
> > +  /* calculate a pts based on rtptime and arrival time (dts) */
> > +  pts = rtp_jitter_buffer_calculate_pts (priv->jbuf, dts, rtptime,
> > 
> > Calculating the PTS changes jbuf's state... is this going to cause problems
> > if we later drop this specific packet? Previously we would only change the
> > state once the packet is definitely inserted.
> 
> Very good question. I was worried about this too, but have not found any
> cases (practical or theoretical) where it is a problem. All existing tests
> are passing, but I am very happy to help write up a new test-case to prove
> me wrong though.

It will break for all cases where you get a packet with a completely different
seqnum (and timestamp!) but ignore it as there are not enough consecutive
seqnums following (see the gap code below your PTS calculation, the cases where
it does not go into reset). So for example some spurious packet arriving here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.