[Bug 773073] audioconvert: endian conversion optimization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773073

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338186|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338186:
 --> (https://bugzilla.gnome.org/review?bug=773073&attachment=338186)

I'm generally not very convinced that any changes here are making anything
simpler :)

::: gst-libs/gst/audio/audio-converter.c
@@ +210,1 @@
 audio_chain_free (AudioChain * chain)

That's not nice API IMHO. Freeing something should just free it, not return
some "arbitrary" other thing

It also does not seem to really simplify anything

@@ +1165,3 @@
+  /* walk the chain backwards and free all elements */
+  for (chain = convert->pack_chain; chain; chain = audio_chain_free (chain)) {
+  }

Instead you could also do

chain = convert->pack_chain;
while (chain) {
  next = chain->next;
  audio_chain_free (chain);
  chain = next;
}

If doing that, it would also be nice to not call it pack_chain as it's the
whole chain actually.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.