[Bug 727802] md5 checksum is missing from flac files encoded with encodebin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=727802

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338192|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338192:
 --> (https://bugzilla.gnome.org/review?bug=727802&attachment=338192)

Not sure if this is the right direction to go

::: gst/audioparsers/gstflacparse.c
@@ +797,3 @@
+  if (flacparse->byte_mode) {
+    *skipsize = 0;
+    framesize = map.size;

This would mean that absolutely no parsing at all would happen if upstream has
a BYTE segment, e.g. filesrc ! flacparse. That doesn't seem right.

Also even after a segment update we shouldn't stop parsing IMHO

@@ +1783,3 @@
+        gst_base_parse_set_min_frame_size (GST_BASE_PARSE (flacparse), 0);
+        /* we must drain any pending data before the seek */
+        gst_base_parse_drain (parse);

You probably want to do something with the return value here. Also you can get
segment events that are only updates, not actual seeks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.