[Bug 773341] urisourcebin: Cleanup unused output slot

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773341

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Seungha Yang from comment #7)

> > @@ +1864,3 @@
> > +  /* run drained_task () */
> > +  urisrc->drained_task =
> > +      gst_task_new ((GstTaskFunction) cleanup_slot_loop, urisrc, NULL);
> > 
> > There can also be multiple demuxers, e.g. AVI containing DV, MXF containing
> > MPEG-PS/TS, etc
> 
> Could you kindly explain more about "AVI containing DV, MXF containing
> MPEG-PS/TS"? The "demux" in urisourcebin seems to be only AdaptiveDemux for
> DASH/HLS/Smooth streaming. Are there any case that those multiple adaptive
> demuxers exist at one time?

You're right, it's only for adaptive demuxers here. We're in urisourcebin after
all :)

There's also the "demuxer" field in urisourcebin btw, which is completely
unused. I guess this should be used to store the demuxer and maybe also get an
assertion that it is never set twice? Want to provide a patch on top of your
other patches for that cleanup?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.