[Bug 773073] audioconvert: endian conversion optimization

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Oct 23 14:48:20 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=773073

--- Comment #26 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 338283
  --> https://bugzilla.gnome.org/attachment.cgi?id=338283
Patch for endian conversion fast-path - version 3

>--- a/gst-libs/gst/audio/audio-converter.h
>+++ b/gst-libs/gst/audio/audio-converter.h
>@@ -84,7 +84,8 @@ typedef enum {
> GstAudioConverter *  gst_audio_converter_new             (GstAudioConverterFlags flags,
>                                                           GstAudioInfo *in_info,
>                                                           GstAudioInfo *out_info,
>-                                                          GstStructure *config);
>+                                                          GstStructure *config,
>+                                                          gboolean *in_place);

Can't do this, this is public API and adding a new parameter breaks API and
ABI.



>diff --git a/gst-libs/gst/audio/audio-format.h b/gst-libs/gst/audio/audio-format.h
>index 0fbc415..5a9c06f 100644
>--- a/gst-libs/gst/audio/audio-format.h
>+++ b/gst-libs/gst/audio/audio-format.h
>@@ -266,7 +266,6 @@ GType gst_audio_format_info_get_type (void);
> ...
>-
> ...

Superfluous line/whitespace change, please remove :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list