[Bug 773269] rtpbin: avoid generating errors when rtcp messages are empty and check the queue is not empty

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773269

--- Comment #13 from Alejandro G. Castro <alex at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> Review of attachment 338187 [details] [review]:
> 
> ::: gst/rtpmanager/rtpsession.c
> @@ +4070,3 @@
> +  if (g_queue_is_empty (&data.output)) {
> +    GST_ERROR ("rtpsession: No RTCP packet generated for a timeout");
> +  }
> 
> That's not enough: there will always be buffers in the queue if there are
> sources. They just might be empty buffers.
>

Ok, I didn't understand your point initially.

> @@ -4087,3 @@
>  
> -    if (empty_buffer)
> -      GST_ERROR ("rtpsession: Trying to send an empty RTCP packet");
> 
> I would suggest to add a gboolean "all_empty" outside the loop and
> initialize it to TRUE. Once you find a non-empty buffer, you set it to
> FALSE. If it's TRUE after the loop, do a warning

Ok, I'll do that, thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.