[Bug 727802] md5 checksum is missing from flac files encoded with encodebin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=727802

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338337|none                        |reviewed
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338337:
 --> (https://bugzilla.gnome.org/review?bug=727802&attachment=338337)

::: gst/audioparsers/gstflacparse.c
@@ +1603,3 @@
     res = GST_BASE_PARSE_FLOW_DROPPED;
   } else {
+    if (flacparse->rewriting_header) {

After rewriting the header it might in theory continue with the normal frames

@@ +1788,3 @@
+        gst_base_parse_set_min_frame_size (GST_BASE_PARSE (flacparse), 0);
+        /* we must drain any pending data before the seek */
+        gst_base_parse_drain (parse);

Maybe baseparse should already do that, but this still is problematic for
SEGMENT events that are just updates and no seek

-- 
You are receiving this mail because:
You are the QA Contact for the bug.