[Bug 753591] vaapi: encoders: implement "direct-uploading"

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753591

--- Comment #11 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Josep Torra Valles from comment #9)
> I can't reach github now but I did the following change:
> 
> diff --git a/gst/vaapi/gstvaapipluginbase.c b/gst/vaapi/gstvaapipluginbase.c
> index 7b39d34..8ce5e38 100644
> --- a/gst/vaapi/gstvaapipluginbase.c
> +++ b/gst/vaapi/gstvaapipluginbase.c
> @@ -535,7 +535,7 @@ ensure_sinkpad_allocator (GstVaapiPluginBase * plugin,
> GstVideoInfo * vinfo)
>  
>      if (gst_caps_is_video_raw (plugin->sinkpad_caps)) {
>        usage_flag = GST_VAAPI_IMAGE_USAGE_FLAG_DIRECT_UPLOAD;
> -      alloc_flag = GST_VAAPI_SURFACE_ALLOC_FLAG_LINEAR_STORAGE;
> +      //alloc_flag = GST_VAAPI_SURFACE_ALLOC_FLAG_LINEAR_STORAGE;
>        GST_INFO_OBJECT (plugin, "enabling direct upload in sink allocator");
>      }
> 
> 
> It almost doubles encoder performance.
> 
> Being able to stream 2x4K at 28 and 3x4K at 22 when without it I can just 1x4K at 28
> in my hardware without using LP mode. 

Good, but not enough ;),,,
I guess you are testing with out dmabuf, right ?
Wondering what is performance gap between dmabuf and non-dmabuf mode...

>I can't test LP Mode yet because the
> gpu hangs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.