[Bug 773423] cerbero: Build fixes for taglib on macOS Sierra and Xcode 8

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773423

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338351|accepted-commit_now         |reviewed
             status|                            |
 Attachment #338351|0                           |1
        is obsolete|                            |

--- Comment #5 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Comment on attachment 338351
  --> https://bugzilla.gnome.org/attachment.cgi?id=338351
osx: Fix CMake build when CFLAGS doesn't have -isysroot

I broke this by moving `-isysroot` from CFLAGS to CPPFLAGS in both
darwin.config and ios.config, and I did a partial fix by reverting it in
ios.config.

I think a better fix is to do the same revert in darwin.config since there
might be other (custom Makefile, f.ex) build systems that just read CFLAGS and
ignore CPPFLAGS. I've just committed this fix to Cerbero.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.