[Bug 727802] md5 checksum is missing from flac files encoded with encodebin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=727802

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338344|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338344:
 --> (https://bugzilla.gnome.org/review?bug=727802&attachment=338344)

It can mean either what? If non-audio data is received after a seek after the
header, that would be an error

::: gst/audioparsers/gstflacparse.c
@@ +1788,3 @@
+      if (segment->format == GST_FORMAT_BYTES) {
+        /* we must pass every header update now */
+        gst_base_parse_set_min_frame_size (GST_BASE_PARSE (flacparse), 0);

Only if we know the header size though. This probably has weird effects if you
receive the first BYTES segment?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.